Fix go coverage builds #6369
Merged
Fix go coverage builds #6369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inferno-chromium
changed the title
|
@catenacyber fyi |
inferno-chromium
commented
Sep 1, 2021
| @@ -24,3 +24,6 @@ ENV GOPATH /root/go | |||
| ENV PATH $PATH:/root/.go/bin:$GOPATH/bin | |||
|
|
|||
| RUN install_go.sh | |||
|
|
|||
| COPY ossfuzz_coverage_runner.go $GOPATH | |||
There was a problem hiding this comment.
this needs to be after install_go.sh, otherwise install_go fails.
There was a problem hiding this comment.
Wait. Where is this file located. Is it located in base-builder-go or base-builder-new?
jonathanmetzman
requested changes
Sep 1, 2021
| @@ -24,3 +24,6 @@ ENV GOPATH /root/go | |||
| ENV PATH $PATH:/root/.go/bin:$GOPATH/bin | |||
|
|
|||
| RUN install_go.sh | |||
|
|
|||
| COPY ossfuzz_coverage_runner.go $GOPATH | |||
There was a problem hiding this comment.
Wait. Where is this file located. Is it located in base-builder-go or base-builder-new?
|
that file is in infra/base-images/base-builder-go/ossfuzz_coverage_runner.go |
|
TBR to unblock broken go coverage builds. |
jonathanmetzman
pushed a commit
that referenced
this pull request
Sep 18, 2024
…rotoreflect/desc/protoparse (#12504) I've recently merged a long-lived "v2" branch to main in the `github.com/jhump/protoreflect` repo. The v2 of that repo does _not_ include a protoparse package, since that has been effectively replaced by `github.com/bufbuild/protocompile`. (Since v1.15 of protoreflect, the protoparse package is just API veneer on top of protocompile.) After I did that merge of v2 to main, the fuzzer for the project began to fail since the packages are no longer present: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=71629 So this updates the fuzzer configuration to directly test the underlying protocompile module. There was also a fuzz tester for the `github.com/jhump/protoreflect/dynamic` package, but it was not actually enabled. (It was disabled in #6369 but neither the PR description nor comment threads describe why this test was problematic 🤷.) Anyhow, that package has also been removed for v2, effectively replaced by `google.golang.org/protobuf/types/dynamicpb`. So this PR deletes it completely from the oss-fuzz repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.