sleuthkit: build fuzzer for the XPRESS (MS-XCA) decompressors - #15993
sleuthkit: build fuzzer for the XPRESS (MS-XCA) decompressors#15993MP-GOWTHAM wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
MP-GOWTHAM is a new contributor to projects/sleuthkit. The PR must be approved by known contributors before it can be merged. The past contributors are: arthurscchan, simsong, joachimmetz, DonggeLiu, inferno-chromium, alsophian |
9efc3ba to
0ab0f38
Compare
DavidKorczynski
left a comment
There was a problem hiding this comment.
can we remove the seed files from this repository? Store them upstream or something similar. Also, let us know when upstream lands the new harness and it would be great if you can get maintainer approval as well.
Builds ossfuzz/tsk_xpress_fuzzer.cc from the sleuthkit checkout once the codec lands upstream (sleuthkit/sleuthkit#3531); skips the target if the codec is not present, so the project does not regress in the meantime. Seed corpus was removed per review: the vectors live in the upstream test suite (unit_tests/base/xpress_test_data.h) and can be reused from there once the upstream fuzzer lands (sleuthkit/sleuthkit#3532).
0ab0f38 to
6c4eb79
Compare
|
All review points addressed in the updated commit (6c4eb79):
|
Adds a libFuzzer target for the XPRESS (MS-XCA) decompressors that were added to Sleuth Kit in sleuthkit/sleuthkit#3531:
ossfuzz/tsk_xpress_fuzzer.cc(in the sleuthkit repo) drives both variants: byte 0 selects plain LZ77 or LZ77+Huffman, bytes 1-4 carry the uncompressed size for the Huffman variant, the rest is the compressed stream.tsk/fs/xpress.cexists in the upstream clone, so this PR does not break the project if the codec PR has not landed yet.unit_tests/base/xpress_test_data.his zipped into the output.Verified locally: the fuzzer input layout decodes all 16 corpus vectors to their exact sizes (gcc, -Wall -Wextra clean).