Skip to content

Fix integer dict key restoration in metadata serialization (#2587) #2619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix integer dict key restoration in metadata serialization (#2587) #2619

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6193237
fix(metadata): preserve integer dict keys when restoring from JSON (#…
Emmanuel-Arokiaraj Nov 23, 2025
8b2eb6c
removed testing modules written for fix
Emmanuel-Arokiaraj Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions checkpoint/orbax/checkpoint/_src/metadata/tree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,13 @@ def to_json(self) -> Dict[str, Union[str, int]]:
def from_json(
cls, json_dict: Dict[str, Union[str, int]]
) -> NestedKeyMetadataEntry:

key_name = json_dict[_KEY_NAME]
if isinstance(key_name, str) and key_name.isdigit():
key_name = int(key_name)

return NestedKeyMetadataEntry(
nested_key_name=json_dict[_KEY_NAME],
nested_key_name=key_name,
key_type=KeyType.from_json(json_dict[_KEY_TYPE]),
)

Expand Down Expand Up @@ -145,7 +150,7 @@ def from_json(
def build(cls, keypath: KeyPath) -> KeyMetadataEntry:
return KeyMetadataEntry([
NestedKeyMetadataEntry(
str(tree_utils.get_key_name(k)), _get_key_metadata_type(k)
key_name if isinstance(key_name := tree_utils.get_key_name(k), int) else str(key_name), _get_key_metadata_type(k)
)
for k in keypath
])
Expand Down