Improved typing for validators #995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalten
force-pushed
the
improved-validator-typing
branch
from
d6d6a23 to
4287f41
Compare
Contributor
Author
|
@cricdecyan I rebased to latest master, would be happy about your review |
Contributor
|
@lalten I will review next week. |
cricdecyan
approved these changes
Sep 19, 2022
Contributor
|
@lalten I approved, please rebase the PR so we can merge it. |
Contributor
Author
|
@cricdecyan lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when using the
Measurement.with_validator()method in otherwise strictly typed user code, the line needed a# type: ignore[no-untyped-call].With this patch applied, this is no longer necessary.
This change is