Add FAIL_AND_CONTINUE to just fail a phase. #616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add FAIL_AND_CONTINUE to PhaseResult to indicate to the executor that the phase should just be marked as a failure while continuing onto the next phase.
fahhem
approved these changes
Jul 27, 2017
Contributor
fahhem
left a comment
fahhem
left a comment
There was a problem hiding this comment.
LGTM. I'm a bit worried of the expanding list of PhaseResults, but I don't expect it to get much longer than this
|
@fahhem and @arsharma1 A follow-up question: if I enable the web frontend, will it show a green color (indicating a PASS) or a red color? I can confirm that |
Contributor
|
I'm not working on operhtf anymore, I recommend opening a new issue or something, sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add FAIL_AND_CONTINUE to PhaseResult to indicate to the executor that
the phase should just be marked as a failure while continuing onto the
next phase.