Add integration test for measurement example. Bring existing hello world test into style compliance #1230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….py`
and a shared utility function for tests.
Summary of changes:
- Created `test/examples/test_measurements.py` with a `TestMeasurements`
class to verify the output of `examples/measurements.py`.
- Test checks for DUT ID, overall outcome (FAIL, as expected due to
`inline_phase`), total number of phases (7), and specific
measurement values and outcomes for `hello_phase`, `measure_seconds`,
`inline_phase`, and `multdim_measurements`.
- Added assertions for `validated_measurement` as per your feedback.
- Resolved test failures by ensuring `pandas` is available and by
correctly identifying phase names and counts.
- Created `test/examples/test_utils.py` containing a helper function
`get_phase_by_name(test_case, phases_data, phase_name)`.
- This function retrieves a phase dictionary by its name from the
test output data, making tests more robust to phase order changes.
- It calls `test_case.fail()` if the phase is not found.
- Refactored `test/examples/test_measurements.py` to use the
`get_phase_by_name` utility.
- Refactored `test/examples/test_hello_world.py` to use the
`get_phase_by_name` utility.
- Corrected the phase name used in this test to "hello_world".
The tests in `test_measurements.py` are confirmed to pass. The final
run of `test_hello_world.py` after its last correction was pending
but is expected to pass.
…rent working directory, since it's messy to have output files show up in the source tree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is