OpenSL ES: Call processBufferCallback before setting the playstate to playing

[robertwu1]

Fixes #1567

If processBufferCallback() is called after setPlayState_l(SL_PLAYSTATE_PLAYING), there could be cases where onAudioReady() is called from two threads.

We should not release the lock just for processBufferCallback(), so there is a minor refactor here. processBufferCallback() now returns a bool and that bool is used to determine whether requestStop_l() should be called.

[flamme]

Do you also need to call requestStop_l in bqCallbackGlue? See

oboe/src/opensles/AudioStreamOpenSLES.cpp

Line 349 in 1e19ec7

(reinterpret_cast<AudioStreamOpenSLES *>(context))->processBufferCallback(bq);

[robertwu1]

Do you also need to call requestStop_l in bqCallbackGlue? See

oboe/src/opensles/AudioStreamOpenSLES.cpp

Line 349 in 1e19ec7

(reinterpret_cast<AudioStreamOpenSLES *>(context))->processBufferCallback(bq);

Nice catch!

[robertwu1]

Most recent commit simply caches the buffer depth as we suspect that calling setPlayState_l changes the buffer depth