Support output format options #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
shinfan
commented
Aug 30, 2018
shinfan
commented
- Support bear/pretty/json/json_compact/header
- Make FindJSONCredentials in sgauth visible so it can be leveraged by oauth2l
- Support bear/pretty/json/json_compact/header
shinfan
requested review from
bochunz and
wora
and removed request for
bochunz
|
@bochunz Can you please review this? |
bochunz
reviewed
Sep 7, 2018
| @@ -36,5 +36,9 @@ func SSOFetch(email string, cli string, task string, scope string) { | |||
| if err != nil { | |||
| fmt.Println(err) | |||
| } | |||
| PrintToken("Bearer", out.String(), task == "header") | |||
| if task == "header" { | |||
There was a problem hiding this comment.
why not call printToken from here?
There was a problem hiding this comment.
printToken() now takes sgauth.Token* type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.