Support QuotaUser/Project and IAMAuthToken #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
shinfan
commented
Aug 29, 2018
shinfan
commented
- Attach fields into headers in both HTTP and gRPC
- Refactor the gRPC token source code for better readability
- Move HTTP transport code into internal/http.go
- Attach fields into headers in both HTTP and gRPC - Refactor the gRPC token source code for better readability - Move HTTP transport code into internal/http.go
|
@julianshaoliu FYI |
shinfan
changed the title
wora
reviewed
Aug 30, 2018
go/sgauth/internal/const.go
Outdated
| const ( | ||
| headerAuth = "authorization" | ||
| headerApiKey = "X-Goog-Api-Key" | ||
| headerQuotaUser = "X-Goog-QuotaUser" |
There was a problem hiding this comment.
go/system-parameters documents it as "X-Goog-QuotaUser", I will correct the documentation.
There was a problem hiding this comment.
The latest version is already corrected to Quota-User. It is just not released yet.
go/sgauth/settings.go
Outdated
| // End-user OAuth Flow handler that redirects the user to the given URL | ||
| // and returns the token. | ||
| OAuthFlowHandler func(url string) (token string, err error) | ||
|
|
||
| // The state string used for 3LO session verification. | ||
| State string |
There was a problem hiding this comment.
Document most features as Unimplemented even you write the code. Many features don't exist yet.
There was a problem hiding this comment.
Domain-wide delegation and State are now marked as unimplmented since I have not implemented the code yet.
I assume quota user and IAM auth token are not available for public. Please let me know if I miss anything.
|
@wora PTAL |
wora
approved these changes
Aug 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.