Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update oauth2l Go to match with the Python. #43

Merged
merged 2 commits into from
Aug 10, 2018
Merged

Update oauth2l Go to match with the Python. #43

merged 2 commits into from
Aug 10, 2018

Conversation

shinfan
Copy link
Collaborator

@shinfan shinfan commented Aug 8, 2018 •
edited
Loading

  • Remove outdated oauth2client/ and oauth2utl/
  • Update oauth2l/main.go CLI interface to match with Python version.
    • Support fetch|header|info|test operations
    • Support --jwt and --sso --ssocli
  • Refactor the code structure to create oauth2l/util package so the main.go can be minimum.
  • Add README doc for Go version.

Note:

  • Python version has a '-f' format option for 'fetch' operation. Currently this is not implemented in this PR.
  • Cache is not implemented in this PR.

@shinfan shinfan requested review from bochunz and wora August 8, 2018 22:58
bochunz
bochunz approved these changes Aug 9, 2018
View reviewed changes
go/oauth2l/main.go Outdated
if file != "" {
secretBytes, err := ioutil.ReadFile(file)
if err != nil {
panic(fmt.Sprintf("Failed to read file %s.\n", file))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return err instead of panic

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@shinfan
Copy link
Collaborator Author

shinfan commented Aug 9, 2018

@bochunz PTAL

@wora
Copy link
Contributor

wora commented Aug 10, 2018

LGTM

@wora wora merged commit 215b0ba into google:master Aug 10, 2018
@wora wora mentioned this pull request Aug 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bochunz bochunz bochunz approved these changes

@wora wora Awaiting requested review from wora

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shinfan @wora @bochunz @googlebot