Reject mount destination path traversal - #298
Draft
AliAltivate wants to merge 1 commit into
Draft
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject mount destinations containing
..path components in both the legacy and new mount APIs.Security impact
MountPt.dstis documented as the mount point inside the jail, but the legacy path-based implementation and the newopenat-based implementation accepted traversal components. A crafted mount configuration such astmp/../../outside_markercould resolve outside the jail root. With a non-mandatorysrc_contentmount, this allowed a file to be written outside the root while nsjail continued successfully.The issue was reproduced locally in a privileged container built from this repository. The same probe affected both mount implementations.
Fix
..components before path or mount side effects in both APIs.Validation
-Wall -Wextra -Werror.git diff --checkpasses.This change intentionally preserves existing handling of other destination components and is limited to preventing lexical path traversal.