Add console action test base case #2762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can probably improve on this in the future if we want, but there's a lot of boilerplate that we don't need to repeat over and over
ptkach
approved these changes
Jun 4, 2025
There was a problem hiding this comment.
The other thing that seems to be repetitive is user creation. It can be added here or separately.
Reviewed 16 of 16 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @gbrodman)
gbrodman
commented
Jun 4, 2025
There was a problem hiding this comment.
yeah, i was thinking that (other than the standard FTE user) we punt on that for now since that is a bit bespoke to each test
Reviewable status:
qrtp
pushed a commit
to unstoppabledomains/nomulus
that referenced
this pull request
Jun 27, 2025
We can probably improve on this in the future if we want, but there's a lot of boilerplate that we don't need to repeat over and over
qrtp
pushed a commit
to unstoppabledomains/nomulus
that referenced
this pull request
Jun 27, 2025
We can probably improve on this in the future if we want, but there's a lot of boilerplate that we don't need to repeat over and over
qrtp
pushed a commit
to unstoppabledomains/nomulus
that referenced
this pull request
Jun 27, 2025
We can probably improve on this in the future if we want, but there's a lot of boilerplate that we don't need to repeat over and over
qrtp
pushed a commit
to unstoppabledomains/nomulus
that referenced
this pull request
Jun 27, 2025
We can probably improve on this in the future if we want, but there's a lot of boilerplate that we don't need to repeat over and over
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can probably improve on this in the future if we want, but there's a lot of boilerplate that we don't need to repeat over and over
This change is