Fix create_cdns_tld command #2760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Cloud DNS rest api is now case-sensitive about enum names (must be lower case, counterintuitively).
CydeWeys
approved these changes
Jun 3, 2025
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @weiminyu)
qrtp
pushed a commit
to unstoppabledomains/nomulus
that referenced
this pull request
Jun 27, 2025
The Cloud DNS rest api is now case-sensitive about enum names (must be lower case, counterintuitively).
qrtp
pushed a commit
to unstoppabledomains/nomulus
that referenced
this pull request
Jun 27, 2025
The Cloud DNS rest api is now case-sensitive about enum names (must be lower case, counterintuitively).
qrtp
pushed a commit
to unstoppabledomains/nomulus
that referenced
this pull request
Jun 27, 2025
The Cloud DNS rest api is now case-sensitive about enum names (must be lower case, counterintuitively).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Cloud DNS rest api is now case-sensitive about enum names (must be lower case, counterintuitively).
This change is