Skip to content

mozc_tip32.dll build with Bazel is not 32-bit binary #1102

Closed

Description

Description

mozc_tip32.dll build with Bazel is actually 64-bit binary.

This is a regression introduced by de7615f.

The root cause is that --cpu command line option has been ignored since Bazel 7.0.

As we still rely on --cpu command line option here, we cannot remove --noincompatible_enable_cc_toolchain_resolution until we fully migrate to --platforms command line option.

def _win_executable_transition_impl(
settings, # @unused
attr):
features = []
if attr.static_crt:
features = ["static_link_msvcrt"]
return {
"//command_line_option:features": features,
"//command_line_option:cpu": attr.cpu,
}
_win_executable_transition = transition(
implementation = _win_executable_transition_impl,
inputs = [],
outputs = [
"//command_line_option:features",
"//command_line_option:cpu",
],
)

Our GYP build is not affected by this issue.

Steps to reproduce

Steps to reproduce the behavior:

  1. Build Mozc64.msi
  2. dotnet tool run wix msi decompile Mozc64.msi -x dump
  3. dumpbin /headers dump\File\mozc_tip32.dll | findstr machine

Expected behavior

14C machine (x86)

Actual behavior

8664 machine (x64)

Version or commit-id

74384fd

Environment

  • OS: Windows 11 23H2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions