Skip to content

Commit

Permalink
Remove unnecessary files from 'protoc_sources'
Browse files Browse the repository at this point in the history
If a file is already included in 'protobuf_sources', there is no need to have
the same file in 'protoc_sources', as the 'protoc' target already depends on
'protobuf' target.

This is a mechanical cleanup for GYP build.  There must be no difference in the
build artifacts anyway.

This is a preparation for #803.

#codehealth

PiperOrigin-RevId: 563447681
  • Loading branch information
yukawa authored and hiroyuki-komatsu committed Sep 7, 2023
1 parent c643a85 commit 93d2f7c
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/protobuf/protobuf.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -75,14 +75,10 @@
],
# Sources for protoc (common part and C++ generator only).
'protoc_sources': [
'<!@(<(glob_protobuf) . cpp_features.pb.cc)',
'<!@(<(glob_protobuf) . "*.cc" --exclude "*.pb.cc" reflection_tester.cc)',
'<!@(<(glob_protobuf) compiler "*.cc" --exclude "*_tester.cc" fake_plugin.cc main.cc)',
'<!@(<(glob_protobuf) compiler/allowlists "*.cc")',
'<!@(<(glob_protobuf) compiler/cpp "**/*.cc")',
'<!@(<(glob_protobuf) io "*.cc")',
'custom_protoc_main.cc',
'<!@(<(glob) --notest --base <(protobuf_root)/third_party/utf8_range "*.cc")',
],
},
'targets': [
Expand Down

0 comments on commit 93d2f7c

Please sign in to comment.