Refactor: Improve subprocess timeout handling #987
+19
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactors `run_command` to use `subprocess.Popen.communicate(timeout=...)` for a more robust timeout mechanism. The old method, relying on a custom `threading.Timer`, could fail to terminate stubborn processes like `fastboot oem dmesg` which ignore `SIGTERM`. The new approach uses `communicate()`, which sends a forceful `SIGKILL` on timeout, guaranteeing the process is terminated. This change also updates the code to use the modern `text` argument introduced in Python 3.7 to replace `universal_newlines`.
xianyuanjia
approved these changes
Aug 20, 2025
xpconanfan
reviewed
Aug 28, 2025
| cwd=cwd, | ||
| env=env, | ||
| universal_newlines=universal_newlines, | ||
| text=universal_newlines, # "text" is introdcued in Python 3.7. |
Collaborator
There was a problem hiding this comment.
is text functionally identical to universal_newline?
Collaborator
Author
There was a problem hiding this comment.
Yes, text is the modern and preferred keyword for handling text mode. universal_newlines is the older and deprecated equivalent.
mhaoli
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors
run_commandto usesubprocess.Popen.communicate(timeout=...)for a more robust timeout mechanism.The old method, relying on a custom
threading.Timer, could fail to terminate stubborn processes likefastboot oem dmesgwhich ignoreSIGTERM. The new approach usescommunicate(), which sends a forcefulSIGKILLon timeout, guaranteeing the process is terminated.This change also updates the code to use the modern
textargument introduced in Python 3.7 to replaceuniversal_newlines.