Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support web components (MVP for labs) #416

Merged
merged 12 commits into from
Jun 17, 2024

Conversation

wwwillchen
Copy link
Collaborator

@wwwillchen wwwillchen commented Jun 11, 2024

Closes #95.

Design doc: https://docs.google.com/document/d/1Nc7Ub8DMNSxAmFuPRdyrlZXh_AoxVjZM-YEeWF8dAyI/edit?usp=sharing

Summary:

  • Implements web component with support for bi-directional communication (between Python<->JavaScript), slots and loading JS modules.
  • Adds docs to explain web components.
  • Provides a few examples for creating web components & corresponding E2E tests.

@wwwillchen wwwillchen marked this pull request as draft June 11, 2024 06:43
@wwwillchen wwwillchen force-pushed the custom_components_lit branch from a3e74ac to 74c4eff Compare June 11, 2024 06:45
@wwwillchen wwwillchen force-pushed the custom_components_lit branch from 74c4eff to 324f4cb Compare June 14, 2024 23:52
@wwwillchen wwwillchen force-pushed the custom_components_lit branch from 9e03f52 to 2b7dfb6 Compare June 17, 2024 06:37
@wwwillchen wwwillchen changed the title Custom components lit (prototype) Support web components (MVP for labs) Jun 17, 2024
@wwwillchen wwwillchen force-pushed the custom_components_lit branch from 65cdff2 to fc42aa0 Compare June 17, 2024 07:13
@wwwillchen wwwillchen force-pushed the custom_components_lit branch from fc42aa0 to 819b5be Compare June 17, 2024 07:37
@wwwillchen wwwillchen requested a review from richard-to June 17, 2024 07:50
@wwwillchen wwwillchen marked this pull request as ready for review June 17, 2024 07:50
Copy link
Collaborator

@richard-to richard-to left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - This looks awesome. I'm really excited about trying this feature out. Such a critical and important feature and I'm really glad we settled on the web components approach over the angular one.

@wwwillchen
Copy link
Collaborator Author

LGTM - This looks awesome. I'm really excited about trying this feature out. Such a critical and important feature and I'm really glad we settled on the web components approach over the angular one.

Thanks! I'm glad you nudged me to support this :)

@wwwillchen wwwillchen force-pushed the custom_components_lit branch from b22c99c to c980788 Compare June 17, 2024 23:34
@wwwillchen wwwillchen force-pushed the custom_components_lit branch from c980788 to c2e7a8b Compare June 17, 2024 23:44
@wwwillchen wwwillchen merged commit 9efab77 into google:main Jun 17, 2024
1 check passed
@simkimsia
Copy link
Contributor

Sorry I read that

Adds docs to explain web components.

Are the docs live?

My interest with this is because I hope to be able to write a react custom component that i can add to Astro frontend.

@wwwillchen
Copy link
Collaborator Author

Yeah the docs are at https://google.github.io/mesop/web_components/, please check it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support custom web components
4 participants