Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using strings.EualFold() for efficient string comparison #305

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Using strings.EualFold() for efficient string comparison #305

merged 1 commit into from
Feb 24, 2020

Conversation

vivekv96
Copy link
Contributor

Advantages -

  1. Efficient and more optimal in all cases, refer https://www.digitalocean.com/community/questions/how-to-efficiently-compare-strings-in-go for benchmarks.
  2. More readable code.
  3. Still uses the standard library.

@bramhaghosh bramhaghosh merged commit dacbe1a into google:master Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@admtnnr admtnnr admtnnr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vivekv96 @admtnnr @bramhaghosh