Fix a memory leak in logging

Closes #36
google · Aug 18, 2014 · b1d7f54 · b1d7f54
1 parent 1a13693
commit b1d7f54
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/base/logging.cc b/base/logging.cc
@@ -60,9 +60,6 @@ Mutex *InitLogSilencerMutex() {
 void InitLogSilencerCount() {
   log_silencer_count_mutex_ = InitLogSilencerMutex();
 }
-void InitLogSilencerCountOnce() {
-  log_silencer_count_mutex_ = new Mutex();
-}
 
 LogMessage& LogMessage::operator<<(const string& value) {
   message_ += value;
@@ -109,7 +106,7 @@ void LogMessage::Finish() {
   bool suppress = false;
 
   if (level_ != LOGLEVEL_FATAL) {
-    InitLogSilencerCountOnce();
+    InitLogSilencerCount();
     MutexLock lock(log_silencer_count_mutex_);
     suppress = log_silencer_count_ > 0;
   }
@@ -147,13 +144,13 @@ LogHandler* SetLogHandler(LogHandler* new_func) {
 }
 
 LogSilencer::LogSilencer() {
-  internal::InitLogSilencerCountOnce();
+  internal::InitLogSilencerCount();
   MutexLock lock(internal::log_silencer_count_mutex_);
   ++internal::log_silencer_count_;
 };
 
 LogSilencer::~LogSilencer() {
-  internal::InitLogSilencerCountOnce();
+  internal::InitLogSilencerCount();
   MutexLock lock(internal::log_silencer_count_mutex_);
   --internal::log_silencer_count_;
 };