Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lfjs: support b2Contact.SetEnabled and fix b2WorldManifold.GetPoint #74

Merged
merged 2 commits into from
Jul 17, 2017

Conversation

haskasu
Copy link
Contributor

@haskasu haskasu commented Jul 17, 2017

for javascript version.

  1. add support for b2Contact.SetEnabled and b2Contact.IsEnabled

  2. b2WorldManifold.GetPoint, each point data position interval should be 8 instead of 2

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@haskasu
Copy link
Contributor Author

haskasu commented Jul 17, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@stewartmiles
Copy link
Contributor

Looks great thanks for the patch.

@stewartmiles stewartmiles merged commit 36e1c3f into google:master Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants