Finished JS bindings for basic collision filtering #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The compiled JavaScript files should be updated by someone else, because my version of emcc creates a ~14kB larger output file, which seems unreasonable. |
|
Apologies for the slow response on this. Patch looks fine. w.r.t the larger compiled JavaScript, 14kB in the context of the rest of the library doesn't sound too bad, we would be happy to merge an update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds JavaScript bindings for b2Fixture.Refilter, and a JavaScript version of b2Fixture.SetFilterData. It also makes b2Body set the fixture's filter from the fixtureDef.