choose gainmap application space adaptively basing on input gamuts #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
during generateGainMap, the color spaces of hdr intent and sdr intent are unified. if a wider gamut space is converted to narrower-gamut this may result in pixel values less than zero and/or greater than 1. choosing offsets to keep the domain of log during gainmap computation is tricky. This can be mitigated by converting narrower gamut space data to wider gamut space. This yields lesser overrange values. current change implements this. for this to work as intended writing xmp metadata in the bitstream needs to be disabled. Test: ./ultrahdr_app options Co-authored-by: Vivek R Jadhav <vivek.jadhav@ittiam.com> Change-Id: I0155a1dc043f3c3e0493e04e5a6eabe160659476
DichenZhang1
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
during generateGainMap, the color spaces of hdr intent and sdr intent are unified. if a wider gamut space is converted to narrower-gamut this may result in pixel values less than zero and/or greater than 1. choosing offsets to keep the domain of log during gainmap computation is tricky. This can be mitigated by converting narrower gamut space data to wider gamut space. This yields lesser overrange values. current change implements this.
for this to work as intended writing xmp metadata in the bitstream needs to be disabled.
Test: ./ultrahdr_app options
Change-Id: I0155a1dc043f3c3e0493e04e5a6eabe160659476