Repository navigation
fix(cpp): use RFC3966 extension syntax in FormatByPattern - #4087
Open
thevilledev wants to merge 1 commit into
Open
thevilledev wants to merge 1 commit into
thevilledev wants to merge 1 commit into
Conversation
FormatByPattern always appended the extension in national style, so RFC3966 output ended in " ext. 1234" instead of ";ext=1234". That is not a valid tel URI and differs from Format(), which already formats the extension for the requested number format, and from the Java and JavaScript formatByPattern. Pass the requested number format through. Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FormatByPatternalways appended the extension in national style, so RFC3966 / RFC 5341 output ended in " ext. 1234" instead of ";ext=1234". That is not a valid tel URI and differs fromFormat(), which already formats the extension for the requested number format, and from the Java and JavaScriptformatByPattern. Pass the requested number format through.