Conversation
fyrsta7
marked this pull request as ready for review
August 8, 2026 15:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1339 by keeping
BlockBuilder's restart counter consistent whenTableBuilder::ChangeOptionslowersblock_restart_intervalafter entries have already been added.Details
BlockBuilder::counter_tracks how many entries have been emitted since the last restart point. IfChangeOptionsinstalls a smaller restart interval whilecounter_is already larger than that interval, the nextAddcan violate the builder's restart interval invariant.This adds an
OnOptionsChangedhook that clamps the counter to the current interval after the table builder updates its options. The new regression test builds a table block under interval 16, changes the interval to 2, adds another entry, finishes and reopens the table, and verifies that the entry can be found through an iterator.Validation
I built and ran the repository's complete
leveldb_testsbinary. Of 212 tests, 211 passed and one compression-dependent test was skipped by the current build configuration; there were no failures.I also ran the new regression test and the full
TableTest.*group separately:git diff --checkalso passes.