Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Why KSP #309

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update Why KSP #309

wants to merge 1 commit into from

Conversation

dwiner
Copy link

@dwiner dwiner commented Feb 12, 2021

Use Room comparison instead of Glide to align with README and other public docs.

Use Room comparison instead of Glide to align with README and other public docs.
Copy link
Contributor

@neetopia neetopia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this paragraph be changed as well in this case?

@dwiner
Copy link
Author

dwiner commented Feb 19, 2021

Should this paragraph be changed as well in this case?

Sorry for the delay on this. You're right. I think it may make sense to hold off on updating this until we're able to share the raw numbers from Room, though, since ideally we want a comparable paragraph with the actual numbers for the amount of time spent on each step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants