Replace usages of findProperty #2034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`findProperty` is not compatible with project isolation. The new `providers.gradleProperty` is however. This partially fixes google#1752
ansman
force-pushed
the
fix/project-isolation
branch
from
22b5b8b to
d3de64c
Compare
ting-yuan
approved these changes
Aug 20, 2024
Contributor
|
I'd like to request that this be either reverted or expose another way to enable/disable KSP2 per-project or per-task. With this change, it can only be enabled/disabled globally because |
ansman
added a commit
to ansman/ksp
that referenced
this pull request
Sep 6, 2024
With the change in google#2034 a side effect was that KSP2 had to be enabled per Gradle project, not per module. With this change a DSL property has been added to handle this.
Contributor
Author
|
@ZacSweers Fix in #2089 |
ansman
added a commit
to ansman/ksp
that referenced
this pull request
Sep 6, 2024
With the change in google#2034 a side effect was that KSP2 had to be enabled per Gradle project, not per module. With this change a DSL property has been added to handle this.
ansman
added a commit
to ansman/ksp
that referenced
this pull request
Sep 26, 2024
With the change in google#2034 a side effect was that KSP2 had to be enabled per Gradle project, not per module. With this change a DSL property has been added to handle this.
ansman
added a commit
to ansman/ksp
that referenced
this pull request
Sep 26, 2024
With the change in google#2034 a side effect was that KSP2 had to be enabled per Gradle project, not per module. With this change a DSL property has been added to handle this.
ting-yuan
pushed a commit
that referenced
this pull request
Sep 27, 2024
With the change in #2034 a side effect was that KSP2 had to be enabled per Gradle project, not per module. With this change a DSL property has been added to handle this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
findPropertyis not compatible with project isolation. The newproviders.gradlePropertyis however.This partially fixes #1752