Move KSP to an independent Gradle task #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also turn incremental compilation back on. Note that incremental processing is still under construction.
ting-yuan
force-pushed
the
gradle-task
branch
from
c217e7e
to
b21f7c9
Compare
neetopia
approved these changes
Oct 27, 2020
ZacSweers
reviewed
Nov 3, 2020
| // kotlinc's incremental compilation isn't compatible with symbol processing in a few ways: | ||
| // * It doesn't consider private / internal changes when computing dirty sets. | ||
| // * It compiles iteratively; Sources can be compiled in different rounds. | ||
| incremental = false |
There was a problem hiding this comment.
The PR description says it was reenabled but this seems to suggest it's not?
There was a problem hiding this comment.
Incremental compilation is back on in the compilation Gradle task, but incremental processing is off in the new ksp specific Gradle task, as the later is still under construction :-)
This was referenced Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also turn incremental compilation back on.
Note that incremental processing is still under construction.