Skip to content

change the modifiers to private from public and lift return out of 'if' #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 9, 2022
Merged

change the modifiers to private from public and lift return out of 'if' #1088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b3590c6
fix: change some codes to not use platform type
Aug 31, 2022
8810043
fix: Lift return out of 'if'
Aug 31, 2022
ab79e92
removes the codes that written the explicit type
Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions api/src/main/kotlin/com/google/devtools/ksp/utils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,10 +234,10 @@ fun KSDeclaration.isPrivate() = this.modifiers.contains(Modifier.PRIVATE)
fun KSDeclaration.isJavaPackagePrivate() = this.getVisibility() == Visibility.JAVA_PACKAGE

fun KSDeclaration.closestClassDeclaration(): KSClassDeclaration? {
if (this is KSClassDeclaration) {
return this
return if (this is KSClassDeclaration) {
this
} else {
return this.parentDeclaration?.closestClassDeclaration()
this.parentDeclaration?.closestClassDeclaration()
}
}

Expand Down
2 changes: 1 addition & 1 deletion kotlin-analysis-api/src/main/kotlin/com/google/devtools/ksp/impl/CommandLineKSPLogger.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import com.google.devtools.ksp.symbol.KSNode

class CommandLineKSPLogger : KSPLogger {
// TODO: support logging level.
val messager = System.err
private val messager = System.err
override fun logging(message: String, symbol: KSNode?) {
messager.println(message)
}
Expand Down