This repository was archived by the owner on Oct 11, 2024. It is now read-only.
Use the CONIKS hasher #728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is currently failing because the verifier algorithm is not handling empty proofs that pass through empty branches properly. Fix coming soon. |
liamsi
suggested changes
Aug 4, 2017
Contributor
There was a problem hiding this comment.
Awesome :-) This LGTM!
The following tests fail on VerifyMapInclusionProof though:
TestEmptyGetAndUpdateTestUpdateValidationTestListHistory
The problem here is that initially (when the leaf hasn't been written yet), the client seems to do sth. slightly different than the keyserver. I'm currently investigating.
Contributor
|
Just saw your comment. Awesome! |
Closed
The moment of truth! - Where we finally switch back to using the CONIKS hashing algorithm successfully :-)
Contributor
Author
|
It WORKS! 💯 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The moment of truth! - Where we finally switch back to using the CONIKS
hashing algorithm successfully :-)
related to google/trillian#780