Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

Conversation

@liamsi
Copy link
Contributor

@liamsi liamsi commented Aug 1, 2017

  • add admin client to key-server
  • add Public() method to VRF private key
  • add GetDomainInfo to proto and key-server

resolves #672

@liamsi liamsi requested a review from gdbelvin August 1, 2017 15:59
Copy link
Contributor

@gdbelvin gdbelvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@liamsi
Copy link
Contributor Author

liamsi commented Aug 1, 2017

I'm fixing the integration test and will merge if travis passes.

cc @AMarcedone that is the PR Gary was referring to during the hangout. You should be able to read the key (der encoded) by querying the API with the corresponding URL (see #672)

@AMarcedone
Copy link
Contributor

Awesome @liamsi!
Looking forward to have this merged so I can start testing grpc from Android. In the meantime I will try to deploy my own version.

@liamsi liamsi force-pushed the discovery branch 2 times, most recently from 52ae7b0 to 84cd054 Compare August 1, 2017 17:47
@liamsi liamsi force-pushed the discovery branch 2 times, most recently from 56d81b1 to a096d13 Compare August 1, 2017 18:04
@liamsi liamsi merged commit 77c2014 into google:master Aug 1, 2017
@codecov-io
Copy link

Codecov Report

Merging #722 into master will decrease coverage by 0.59%.
The diff coverage is 9.75%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #722     +/-   ##
=========================================
- Coverage   53.85%   53.25%   -0.6%     
=========================================
  Files          38       38             
  Lines        3168     3207     +39     
=========================================
+ Hits         1706     1708      +2     
- Misses       1171     1208     +37     
  Partials      291      291
Impacted Files Coverage Δ
core/crypto/vrf/vrf.go 100% <ø> (ø) ⬆️
core/crypto/vrf/p256/p256.go 75.13% <0%> (-5.68%) ⬇️
integration/testutil.go 65.21% <100%> (+0.25%) ⬆️
core/keyserver/keyserver.go 36.36% <4%> (-3.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1bfcfd...e6a39f0. Read the comment docs.

@liamsi liamsi changed the title Add API to publish verification data Server/domaininfo: Add API to publish verification data Aug 15, 2017
@liamsi liamsi changed the title Server/domaininfo: Add API to publish verification data Server: publish verification data on v1/domain/info Aug 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Server should publish verification data

4 participants