This repository was archived by the owner on Oct 11, 2024. It is now read-only.
Updated instructions for local deployment #1582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
List of changes: 1) Created a new script from "docker-compose_test.sh" that allows users to deploy, and later cleanup, the KeyTransparency service locally; 2) Updated the README's related section with the new script's usage; 3) Substituted the instruction `go get github.com/google/keytransparency/...` which fails due to missing (autogenerated ?) files, with the equivalent `git clone` version; 4) Fixed the key file existance check in script "docker-compose_test.sh";
gmichelo
commented
Jul 12, 2020
| - Docker Compose 1.11.0+ `docker-compose --version` | ||
|
|
||
| ```sh | ||
| go get github.com/google/keytransparency/... |
Contributor
Author
There was a problem hiding this comment.
This failed with the below error message:
$ go get github.com/google/keytransparency/...
# github.com/google/keytransparency/impl/authorization/authz_go_proto
../google/keytransparency/impl/authorization/authz_go_proto/authz.pb.go:40:11: undefined: "github.com/golang/protobuf/proto".ProtoPackageIsVersion4
# github.com/google/keytransparency/core/sequencer/sequencer_go_proto
../google/keytransparency/core/sequencer/sequencer_go_proto/sequencer_api.pb.go:50:11: undefined: "github.com/golang/protobuf/proto".ProtoPackageIsVersion4
../google/keytransparency/core/sequencer/sequencer_go_proto/sequencer_api.pb.go:1205:7: undefined: grpc.ClientConnInterface
../google/keytransparency/core/sequencer/sequencer_go_proto/sequencer_api.pb.go:1209:11: undefined: grpc.SupportPackageIsVersion6
../google/keytransparency/core/sequencer/sequencer_go_proto/sequencer_api.pb.go:1234:5: undefined: grpc.ClientConnInterface
../google/keytransparency/core/sequencer/sequencer_go_proto/sequencer_api.pb.go:1237:43: undefined: grpc.ClientConnInterfaceIt seems to be related to some autogenerated file not committed in the repo.
Codecov Report
@@ Coverage Diff @@
## master #1582 +/- ##
==========================================
- Coverage 69.66% 69.55% -0.12%
==========================================
Files 59 59
Lines 4385 4385
==========================================
- Hits 3055 3050 -5
- Misses 898 901 +3
- Partials 432 434 +2
Continue to review full report at Codecov.
|
NatalieDoduc
reviewed
Oct 1, 2020
NatalieDoduc
left a comment
NatalieDoduc
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for making the changes and updating the README.
Let me find and add a current OWNER from keytransparency for Approval.
eomara
approved these changes
Oct 1, 2020
eomara
approved these changes
Oct 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes:
users to deploy, and later cleanup, the KeyTransparency service
locally;
go get github.com/google/keytransparency/...which fails due to missing (autogenerated ?) files, with the
equivalent
git cloneversion;Fixes #1581