Skip to content

blocks: add double single quote block recognition #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2025
Merged

blocks: add double single quote block recognition #78

merged 1 commit into from
Apr 1, 2025

Conversation

katexochen
Copy link
Contributor

Nix multi line strings use double single quotes. Adding this to the list of quotes that indicate blocks.

@katexochen
feat: add double single quote block recognition
a523474 
Signed-off-by: Paul Meyer <katexochen0@gmail.com>
@katexochen katexochen force-pushed the double-single-quote-blocks branch from 7403d9d to a523474 Compare March 27, 2025 10:06
@katexochen
Copy link
Contributor Author

@JeffFaer for review. :)

@JeffFaer JeffFaer enabled auto-merge (squash) April 1, 2025 16:02
@JeffFaer JeffFaer self-requested a review April 1, 2025 16:02
@JeffFaer
Copy link
Collaborator

JeffFaer commented Apr 1, 2025

Thanks for the PR!

@JeffFaer JeffFaer merged commit 1e5a257 into google:main Apr 1, 2025
5 checks passed
@katexochen katexochen deleted the double-single-quote-blocks branch April 1, 2025 16:05
@JeffFaer
Copy link
Collaborator

Hmm, so I wasn't thinking about it back in April, but '' is also how many languages express an empty string, which shouldn't be treated as a quote. I think we might want to revert this PR, and maybe allow the list of quotes to be customized via a flag or something

JeffFaer added a commit that referenced this pull request Aug 14, 2025
@JeffFaer
Revert "blocks: add double single quote block recognition (#78)"
40d672b 
This reverts commit 1e5a257.
@JeffFaer JeffFaer mentioned this pull request Aug 14, 2025
Merged
JeffFaer added a commit that referenced this pull request Aug 14, 2025
@JeffFaer
Revert "blocks: add double single quote block recognition (#78)" (#89)
6c80cd9 
This reverts commit 1e5a257.

`''` is also how many languages express an empty string, which shouldn't
be treated as a quote. #78 causes quite a few problems for many files
internally, and I assume it'd also cause problems externally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffFaer JeffFaer JeffFaer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katexochen @JeffFaer