fix: Continue to group nested keep-sorted blocks together if both group=yes and block=yes are set. #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…up=yes and block=yes are set. See git history of this PR to see how group.out has changed.
KatrinaHoffert
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
I do low key wonder if the condition should be group or block rather than just doing this in group mode. Group mode is enabled by default, but perhaps it makes sense for nested keep-sorted blocks to still work if for whatever reason we only have block mode enabled. But eh, probably not worth the trouble of having to figure out if it is that simple and making other changes if it's not. This is a nice and minimal change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See git history of this PR to see how group.out has changed.