-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add |||-
chomped text block syntax
#1175
feat: add |||-
chomped text block syntax
#1175
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Resolves google/jsonnet#289 Companion PR to google/jsonnet#1175
Any updates? Anybody willing to review this and weigh in? |
Is there any estimate on when this will get merged (and released)? |
Hi. Thanks for your contribution, and sorry for the delay in processing it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The MathJax change is not needed - that operator list is nothing to do with jsonnet, so it shouldn't be updated for this change. As far as I can tell, those operators originate from the MathML spec - https://www.w3.org/TR/MathML/appendixc.html (the existing triple-pipe fence was added to the table in mathjax/MathJax@bf862f6#diff-8e4e61c67ba8f00ac92875cb211f3a2ec8eef705f71d232d4d3dcb014d0517c0)
The optable in the MathJax code is not related to Jsonnet's syntax, and should not have `|||-` added.
Resolves google/jsonnet#289 Companion PR to google/jsonnet#1175
Resolves google/jsonnet#289 Companion PR to google/jsonnet#1175
Resolves google/jsonnet#289 Companion PR to google/jsonnet#1175
Resolves #289!
Was pretty easy to add as you can see. 🙂
Let me know if you have any concerns or feedback!
Only part I'm not sure of is the changes to doc/third_party/MathJax-2.7.2/unpacked -- it looks like like at
jsonnet/doc/_layouts/base.html
Line 22 in 9952fc5
MathJax.js
, but I can't figure out to re-"pack" the unpacked code. 🤔 I'm also not sure how critical it is though. 🤷🏻♂️Note: I'm working on a companion PR to google/go-jsonnet too.