-
Notifications
You must be signed in to change notification settings - Fork 412
Upgrade to build_runner 0.7 #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
bf40831
acb3c1f
65e3748
c5f680f
5effcc2
fcfcf76
9bc727c
8befa26
d10ca42
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,6 @@ language: dart | |
|
||
dart: | ||
- dev | ||
- stable | ||
|
||
env: | ||
- PKG=example TASK=dartanalyzer | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
# Read about `build.yaml` at https://pub.dartlang.org/packages/build_config | ||
targets: | ||
example: | ||
builders: | ||
json_serializable: | ||
options: | ||
header: |+ | ||
// Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file | ||
// for details. All rights reserved. Use of this source code is governed by a | ||
// BSD-style license that can be found in the LICENSE file. | ||
|
||
// GENERATED CODE - DO NOT MODIFY BY HAND | ||
|
This file was deleted.
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
# Read about `build.yaml` at https://pub.dartlang.org/packages/build_config | ||
builders: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should add a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
json_serializable: | ||
target: ":json_serializable" | ||
import: "package:json_serializable/builder.dart" | ||
builder_factories: ["jsonSerializable"] | ||
build_extensions: {".dart": [".g.dart"]} | ||
auto_apply: dependents | ||
build_to: source |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
// Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file | ||
// for details. All rights reserved. Use of this source code is governed by a | ||
// BSD-style license that can be found in the LICENSE file. | ||
|
||
import 'package:build/build.dart'; | ||
|
||
import 'json_serializable.dart'; | ||
|
||
Builder jsonSerializable(BuilderOptions options) => jsonPartBuilder( | ||
header: options.config['header'] as String, | ||
useWrappers: options.config['use_wrappers'] as bool ?? false); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,14 @@ | ||
name: json_serializable | ||
version: 0.3.0 | ||
version: 0.3.1-dev | ||
author: Dart Team <misc@dartlang.org> | ||
description: Generates utilities to aid in serializing to/from JSON. | ||
homepage: https://github.com/dart-lang/json_serializable | ||
environment: | ||
sdk: '>=1.24.0 <2.0.0' | ||
sdk: '>=2.0.0-dev <2.0.0' | ||
dependencies: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @natebosch – should update the SDK dependency then, too? Right? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. IMO it shouldn't be a requirement. It's pub's job to take dependency SDK constraints into account when version solving. If I'm only using stuff from In practice I think it's fine to do it since we're not testing on older SDKs so we're not confident that we haven't suddenly stopped working for reasons around this package. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
analyzer: '>=0.29.10 <0.31.0' | ||
build: '>=0.9.0 <0.12.0' | ||
build_config: ^0.2.1 | ||
cli_util: ^0.1.0 | ||
|
||
# Use a tight version constraint to ensure that a constraint on | ||
|
@@ -16,7 +17,7 @@ dependencies: | |
path: ^1.3.2 | ||
source_gen: ^0.7.1 | ||
dev_dependencies: | ||
build_runner: ^0.6.0+1 | ||
build_runner: ^0.7.0 | ||
build_test: ^0.9.0 | ||
collection: ^1.14.0 | ||
dart_style: ^1.0.0 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto – add a
# FYI ready about build.yaml here...
line at the top...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done