No source gen dep #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We always want this code to be usable outside the repo since it's referenced directly.
natebosch
approved these changes
Dec 15, 2017
| /// `json_serializable`. | ||
| /// | ||
| /// [example]: https://github.com/dart-lang/json_serializable/tree/master/example | ||
| PartBuilder jsonPartBuilder({String header, bool useWrappers: false}) { |
There was a problem hiding this comment.
why do you need to expose this as PartBuilder? Do you want to expose it instead as a Builder?
* Added a new method: jsonPartBuilder - so folks don't need to reference source_gen * Deprecated generators.dart in favor of json_serializable.dart
kevmoo
force-pushed
the
no_source_gen_dep
branch
from
25ba2b8 to
bb1fb18
Compare
natebosch
approved these changes
Dec 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will update the example once I publish the latest of each package