Support nullable on class annotation, and other cleanup
#61
Conversation
|
I want to do 2 more flavors of changes on top of the |
| final bool includeIfNull; | ||
|
|
||
| /// `true` if the generator should validate all values for `null` in |
There was a problem hiding this comment.
These comments are a bit confusing to me, maybe just change validate/verification to check/checks? Currently it sounds like its validating that things are null or something, I don't really understand it :).
Same goes for other similar comments below.
| /// | ||
| /// Setting to `false` eliminates `null` verification in generated code, but | ||
| /// does not prevent `null` values from being created. Annotated classes | ||
| /// must implement their own `null` validation. |
There was a problem hiding this comment.
... , otherwise you may get runtime errors.
There was a problem hiding this comment.
Did a rewrite. PTAL
| Map _defaultMap() => {}; | ||
|
|
||
| @JsonSerializable(nullable: false) | ||
| class KitchenSinkNullable extends Object |
There was a problem hiding this comment.
Isn't this really a KitchenSinkNonNullable?
| @@ -143,15 +146,16 @@ class JsonSerializableGenerator | |||
| buffer.writeln(' ${field.type} get ${field.name};'); | |||
| } | |||
|
|
|||
| var includeIfNull = annotation.read('includeIfNull').boolValue; | |||
| var classIncludeIfNull = annotation.read('includeIfNull').boolValue; | |||
There was a problem hiding this comment.
I am not a huge fan of passing this around everywhere, it might make more sense to read the JsonKey annotations upfront and fill in defaults, so you can just pass a single configuration object around? Maybe a class that wraps up a FieldElement and a JsonKey?
There was a problem hiding this comment.
Done...a bit... At least for the class annotation
json_annotation: fix doc comments
kevmoo
force-pushed
the
class_nullable
branch
from
114945a to
f9c2c8e
Compare
No description provided.