Fixes to lints and fuzzy arrows #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
approved these changes
Sep 25, 2017
| @@ -54,21 +54,21 @@ String _jsonLiteralAsDart(dynamic value, bool asConst) { | |||
| return '${asConst ? 'const' : ''}[$listItems]'; | |||
| } | |||
|
|
|||
| if (value is Map) return _jsonMapAsDart(value, asConst); | |||
| if (value is Map<String, dynamic>) return _jsonMapAsDart(value, asConst); | |||
There was a problem hiding this comment.
Are these types of checks any more sane than they used to be (won't this return true for Map<dynamic, dynamic>)?
I guess you are just trying to avoid the explicit cast given the tighter type on _jsonMapAsDart, but this sends a bit of the wrong signal imo... I would rather see the cast when you pass the value in to _jsonMapAsDart as its a bit more obvious that you are explicitly casting it and it could technically fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.