Option to omit empty fields #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
force-pushed
the
omit_empty_fields
branch
from
6ee1c16 to
e488748
Compare
Also handle fields with names that overlap with toJSON inline helpers
And update some comments
kevmoo
force-pushed
the
omit_empty_fields
branch
from
b248b44 to
7c131ad
Compare
natebosch
reviewed
Jul 25, 2017
lib/src/json_serializable.dart
Outdated
| const JsonSerializable({bool createFactory: true, bool createToJson: true}) | ||
| : this.createFactory = createFactory, | ||
| this.createToJson = createToJson; | ||
| /// [true] if the generator should include the this field in the serialized |
There was a problem hiding this comment.
[nit] 'Whether the generator should...'
| const JsonSerializable( | ||
| {bool createFactory: true, | ||
| bool createToJson: true, | ||
| bool includeIfNull: true}) |
There was a problem hiding this comment.
why is true the default? Backwards compatibility?
There was a problem hiding this comment.
Yup. It can also lead to some weirdness – like having a completely empty Map returned from toJson – better to make it opt-in.
Also the code generated is a lot uglier.
kevmoo
force-pushed
the
omit_empty_fields
branch
from
7c131ad to
86098bc
Compare
natebosch
approved these changes
Jul 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.