feature: default to creating toJson function instead of a mixin #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
force-pushed
the
to_json_function_by_default
branch
2 times, most recently
from
8345818 to
eba5cd1
Compare
kevmoo
changed the title
kevmoo
force-pushed
the
to_json_function_by_default
branch
from
b5ca08e to
d559dc1
Compare
natebosch
approved these changes
Jul 16, 2018
json_serializable/CHANGELOG.md
Outdated
| * **BREAKING** By default, code generated to support `toJson` now creates | ||
| a top-level function instead of a mixin. | ||
| * The default for the `generate_to_json_function` is now `true`. | ||
| * To opt-out of this change, set `generate_to_json_function` to `false`. |
There was a problem hiding this comment.
do these need to be separate sub bullets? They seem like a continuation of the same thought.
|
Happy to make it a sentence.
…On Mon, Jul 16, 2018 at 11:23 AM Nate Bosch ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In json_serializable/CHANGELOG.md
<#254 (comment)>
:
> @@ -1,5 +1,10 @@
## 0.6.0
+* **BREAKING** By default, code generated to support `toJson` now creates
+ a top-level function instead of a mixin.
+ * The default for the `generate_to_json_function` is now `true`.
+ * To opt-out of this change, set `generate_to_json_function` to `false`.
do these need to be separate sub bullets? They seem like a continuation of
the same thought.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#254 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABCipgP0YdE-Awr_o7tdPbgGa5xnBoKks5uHNoYgaJpZM4VId2B>
.
|
The default for the `generate_to_json_function` is now `true`.
kevmoo
force-pushed
the
to_json_function_by_default
branch
from
b905a68 to
8587a82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default for the
generate_to_json_functionis nowtrue.