Fix for #233 and other things #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
reviewed
Jun 21, 2018
|
|
||
| if (yamlValue == null) { | ||
| assert(err.key == null); | ||
| //assert(err.key == null); |
jakemac53
approved these changes
Jun 21, 2018
Collaborator
jakemac53
left a comment
jakemac53
left a comment
There was a problem hiding this comment.
lgtm other than the commented out line (either delete or restore)
kevmoo
force-pushed
the
i233_handle_format_exception
branch
from
7b81939 to
dd3b7bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will land separately