refactor: prepare for multi-return values in GenerateForAnnotation #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JsonSerializableGenerator now returns String instead of Future<String> GeneratorHelper is now private and in the same file is the Generator Encoding and decoding have been split into mixin classes These two aspects of the generator are nicely isolated hopefully making future fixes and additions easier Many members of utils.dart have been moved closer to where they are used and made private when possible Updated tests to be sync now that the core tested function is sync
jakemac53
reviewed
Jun 18, 2018
| import 'type_helper.dart'; | ||
| import 'utils.dart'; | ||
|
|
||
| abstract class DencodeHelper implements HelperCore { |
jakemac53
reviewed
Jun 18, 2018
| @@ -0,0 +1,302 @@ | |||
| import 'package:analyzer/dart/element/element.dart'; | |||
There was a problem hiding this comment.
copyright (others also)
jakemac53
approved these changes
Jun 18, 2018
Yup. Mostly copy-paste. The mixin thing is pretty nice... |
|
Ya, I like the new structure more for sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JsonSerializableGenerator now returns String instead of Future
GeneratorHelper is now private and in the same file is the Generator
Encoding and decoding have been split into mixin classes
These two aspects of the generator are nicely isolated hopefully
making future fixes and additions easier
Many members of utils.dart have been moved closer to where they are used
and made private when possible
Updated tests to be sync now that the core tested function is sync