Skip to content

Add option for explicitToJson #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2018
Merged

Conversation

kevmoo
Copy link
Collaborator

@kevmoo kevmoo commented Jun 7, 2018

Allows users to opt-in to including .toJson() calls on nested
objects in generated toJson methods.

This is useful if you want to round-trip the output of toJson without
putting it through jsonEncode and jsonDecode

Fixes #192

@kevmoo kevmoo requested review from jakemac53 and natebosch June 7, 2018 17:16
@kevmoo
Copy link
Collaborator Author

kevmoo commented Jun 7, 2018

Since dart:convert does the work to ensure there are no cycles, I'm going to leave this opt-in for users.

@kevmoo
Copy link
Collaborator Author

kevmoo commented Jun 7, 2018

See discussion in previous PR - #195

Allows users to opt-in to including `.toJson()` calls on nested
objects in generated `toJson` methods.

This is useful if you want to round-trip the output of toJson without
putting it through jsonEncode and jsonDecode

Fixes #192
@kevmoo kevmoo force-pushed the i192_call_to_json_automatically branch from 253aa8a to fd874dd Compare June 8, 2018 14:58
@kevmoo kevmoo merged commit fd874dd into master Jun 8, 2018
@kevmoo kevmoo deleted the i192_call_to_json_automatically branch June 8, 2018 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants