Cleanup inference to enable clean DDC compile #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
changed the title
natebosch
approved these changes
Jul 21, 2017
| @@ -76,7 +76,7 @@ class JsonSerializableGenerator | |||
| // Explicitly using `LinkedHashMap` – we want these ordered. | |||
| var fields = new LinkedHashMap<String, FieldElement>.fromIterable( | |||
| fieldsList, | |||
| key: (f) => f.name); | |||
| key: (FieldElement f) => f.name); | |||
There was a problem hiding this comment.
[aside] I'm a little surprised this one is necessary - is fieldsList not well typed?
There was a problem hiding this comment.
Agreed: dart-lang/sdk#26392
natebosch
approved these changes
Jul 21, 2017
CHANGELOG.md
Outdated
|
|
||
| * Fail generation when undefined types are encountered. | ||
| Throw a helpful error. | ||
| * **BREAKING** Fail generation for unsupported types. |
There was a problem hiding this comment.
elaborate on what is unsupported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.