Starting on default value work #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
reviewed
May 25, 2018
| @@ -44,10 +44,11 @@ class TypeHelperContext implements SerializeContext, DeserializeContext { | |||
| (TypeHelper th) => th.deserialize(targetType, expression, this)); | |||
|
|
|||
| String _run(DartType targetType, String expression, | |||
| String invoke(TypeHelper instance)) => | |||
| allHelpersImpl(_generator).map(invoke).firstWhere((r) => r != null, | |||
| String invoke(TypeHelper instance)) { | |||
| 'fieldListEmpty': const [42], | ||
| 'fieldMapEmpty': const {'question': false}, | ||
| 'fieldListSimple': const [4, 5, 6], | ||
| 'fieldMapSimple': const <Null, Null>{}, |
|
@jakemac53 – approved otherwise? |
Progress on #74
kevmoo
force-pushed
the
i74_default_values
branch
from
7126bac to
26b5ced
Compare
jakemac53
approved these changes
May 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to do a bit more with checking types and supporting enums, but this is a good start