latest pkg:source_gen, and a lot of deprecation cleanup #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and support the latest `package:source_gen`.
|
@natebosch – yes, this is a bear. Happy to split it up if it'll help... |
natebosch
reviewed
Mar 30, 2018
json_serializable/build.yaml
Outdated
| import: "package:json_serializable/builder.dart" | ||
| builder_factories: ["jsonSerializable"] | ||
| import: "package:json_serializable/json_serializable.dart" | ||
| builder_factories: ["createBuilderForJsonSerializable"] |
There was a problem hiding this comment.
The changes in this file move away from the conventions we've been trying to establish. Perhaps I should document them somewhere...
Importing from /builder.dart is a signal that the code in here is meant more for the build system than for end users - it's good IMO to keep the builder separate from the annotations.
Having a noun name for the factory makes the build.yaml look a little nicer.
| @@ -0,0 +1,30 @@ | |||
| // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file | |||
|
|
||
| /// Supports `package:build_runner` creation and configuration of `build_cli`. | ||
| /// | ||
| /// Not meant to be invoked by hand-authored code. |
There was a problem hiding this comment.
which is why I like to have it in a separate library 😁
kevmoo
force-pushed
the
latest_source_gen
branch
from
8f3a730 to
3eabbf2
Compare
|
@natebosch PTAL |
natebosch
approved these changes
Mar 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.