Empty object

[Tokenyet]

Enviroment

Flutter 1.10.1-pre.41 • channel master • https://github.com/flutter/flutter.git
Framework • revision 5a3a46ada2 (9 days ago) • 2019-09-07 18:37:41 -0400
Engine • revision c9ea4dba8d
Tools • Dart 2.5.0 (build 2.5.0-dev.4.0 ec7ec4ecf7)
build_runner: ^1.6.1
json_serializable: ^3.1.0

Is there any way to slove {} with builtin way? I had a null object returned {}, so I had to write custom fromJson to JsonKey. Below code sloved my problem, but I wanna check If there is more elegant way to check for all fields.

  static _bankFromJson(Map<String, dynamic> json) {
    if(json['bank'] == null)
      return null;
    else
    {
      if(json['bank'] is Map)
        if(json['bank'].keys.length == 0)
          return null;
      return CompanyBank.fromJson(json['bank'] as Map<String, dynamic>);
    }
  }
  @JsonKey(fromJson: _bankFromJson)
  CompanyBank bank;

[kevmoo]

In this case it looks like you have {"bank":{"bank":...}}, right?

[Tokenyet]

This issue is a bit long for me, but I think It was the problem in the case as below:

{
    "bank": {}
}

This should be fixed in the backend:

{
    "bank": null
}

I'm not sure If I should keep this issue open or not, because this wasn't a workaround for frontend side.

[kevmoo]

I don't think we're going to add special handling here. It'd add too much complexity.

[1207roy]

@kevmoo @Tokenyet
Can you guys please suggest any way to achieve this?
I have been using json_serializable for a very long time and suddenly I have been asked to handle this from the front end side as many third-party APIs are sending this type of empty map in API response json!

[kevmoo]

@1207roy – have you tried using a custom converter?

[1207roy]

@kevmoo
For that, I will need to create that custom converter for all of my models, right?
If yes, I am actually trying to find a way so that I don't need to create them for all of the model classes!

[kevmoo]

@1207roy – I think so.

To be clear on your request here: you want treateEmptyAsNull, right?

[1207roy]

@kevmoo
Yes exactly like that
as @Tokenyet has given the example, I need that for all of my models(consider 100+ models)

So I am thinking, like this:
@JsonSerializable(treateEmptyAsNull: true, explicitToJson: true) and/or
@jsonkey(treateEmptyAsNull: true)

so when the fromJson is generated, it will check always like if it is empty then create it as null, instead of creating an instance with all of its fields as null("bank": {})