-
Notifications
You must be signed in to change notification settings - Fork 38
APP14 Marker, Better Subsampling and High Quality Improvements #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
consider removing personal notes and fixing comment formatting |
|
Build issues should be solved, I've managed to successfully compile on my Ubuntu VM. |
|
Marking as Draft while we do testing and cleaning up. |
|
I am eagerly awaiting the fix for the APP14 Marker (to make XYB work with Safari). Is there something missing or could this be merged? |
|
Testing this PR I noticed that just adding I am using the following commands |
XYB only subsamples the Blue channel, and is most likely higher quality than YCbCr. The difference between them could be due to a number of factors, including the image content itself. |
I was suspecting something like that. It would have been more intuitive if the distance parameter was consistent between the two modes. |
Description
The APP14 tag is now added to RGB(XYB), CMYK and YCCK JPEGs, as it is required in some decoders.
Using
--chroma_subsamplingwill now correctly subsample XYB's Blue channel.XYB is now 444 by default to allow JPEG XL Transcoding.
YCbCr now uses 444 by default and 420 at Quality 80/Distance 1.9 or lower.
Adaptive Quantization is disabled at Quality 90/Distance 1 or lower for non-XYB.
RGB is now used at Quality 100/Distance 0 for RGB input (PNG), overridden by XYB.
Fixes #122
Fixes libjxl/libjxl#3512
Fixes libjxl/libjxl#3605
Pull Request Checklist
./ci.sh lintfor automatic code formatting.Please review the full contributing guidelines for more details.