Don't catch a generic Exception following a multi-catch statement #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -132,6 +132,20 @@ public void testCatchTranslation() throws IOException { | |||
| assertEquals("@try {\n;\n}\n @catch (JavaLangException *e) {\n}", result); | |||
| } | |||
|
|
|||
| public void testMultiCatchTranslation() throws IOException { | |||
There was a problem hiding this comment.
Could you instead merge this into testMultiCatch() below, and use assertTranslatedLines to verify the translation.
There was a problem hiding this comment.
Good call, I had overlooked testMutiCatch() earlier. Updated the pull request but used assertNotInTranslation() instead of assertTranslatedLines() for the sake of brevity. Do you think that's sufficient?
danieldickison
force-pushed
the
multicatch
branch
from
5154642 to
1ab13b2
Compare
|
The Travis build timed out, but at least got past j2objc compilation and translation of jre sources, so I'll pull this anyways. |
|
Thanks for the quick response and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a multi-catch statement like:
is translated to three objc
@catchclauses:The last
@catchclause seems to be the closest common ancestor ofAandB, but from what I understand, this doesn't match the semantics of the Java multi-catch syntax. In fact, if the multi-catch is followed by acatch (C e) {}, whereCalso inheritsRuntimeException, the translated@catch (C *e)clause is never reached because it is shadowed by the extraneous@catchclause.This pull request changes the translation to omit the extra
@catchclause after a multi-catch. Please review because I can't help but think that the extra@catchclause was previously being generated intentionally.