Skip to content

Update GitHub Actions workflow to use Java 17. #2586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update GitHub Actions workflow to use Java 17. #2586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,18 @@ jobs:
MAKE_CMD: "env TRANSLATE_GLOBAL_FLAGS=--swift-friendly ENV_J2OBJC_ARCHS=macosx_iphone64 make -j32"

steps:
- name: java_11_env
run: echo "JAVA_11_HOME=$(/usr/libexec/java_home -v 11)" >> $GITHUB_ENV
- name: java_17_env
run: echo "JAVA_17_HOME=$(/usr/libexec/java_home -v 17)" >> $GITHUB_ENV

- uses: actions/checkout@v2

# Build everything but protobuf targets, which require that the public
# protobuf distribution be installed.
- name: build_all
run: $MAKE_CMD JAVA_HOME=$JAVA_11_HOME frameworks examples_dist
run: $MAKE_CMD JAVA_HOME=$JAVA_17_HOME frameworks examples_dist

# Test command-line tools.
- name: test_tools
run: $MAKE_CMD JAVA_HOME=$JAVA_11_HOME test_translator test_cycle_finder test_jre_cycles
# Disable test_jre_cycles, as cycle_finder fails on Java 17 (https://github.com/tomball/j2objc/issues/1)
Copy link

Copilot AI Oct 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The comment references a temporary workaround but lacks context about when this will be addressed. Consider adding a TODO marker and an expected timeline or condition for re-enabling the test, e.g., 'TODO: Re-enable once cycle_finder supports Java 17 (tracking issue: #1)'.

Suggested change
# Disable test_jre_cycles, as cycle_finder fails on Java 17 (https://github.com/tomball/j2objc/issues/1)
# TODO: Re-enable test_jre_cycles once cycle_finder supports Java 17 (tracking issue: https://github.com/tomball/j2objc/issues/1)

Copilot uses AI. Check for mistakes.
# run: $MAKE_CMD JAVA_HOME=$JAVA_17_HOME test_translator test_cycle_finder test_jre_cycles
run: $MAKE_CMD JAVA_HOME=$JAVA_17_HOME test_translator test_cycle_finder